Corrected formatting for language files with "owner_status" #7743
Conversation
|
When the origin string in the en_us.yml file is altered it will make crowdin replace all of the already-translated languages' string with the new English string. There's a fairly good chance that if this PR is merged it will undo all of the other languages' translations, including what you've submitted in this PR. It would be better if the maphud class usage of the owner_status string had the ": " appended to it. |
|
It is a bit messy seeing as the other ones like "msg_map_hud_district" have the ": " in the language file, but I changed and tested it locally and it works. How would you like me to commit it, seeing as all these language files are not the way they should be committed if it is done like this? |
|
Well if I did accept this PR and it didn't overwrite all of the lang strings on Crowdin, someone would have to go and fix the crowdin translations. This also means that the file changes to the non-English translations are not needed in this PR. The PR should either be one change to the en_US.yml file, or one change to the owner_status component in the MapHUD class. The former will require someone to go and re-translate all of the language files' owner_status on crowdin, while the latter requires only a one-line PR. |
|
I can close this PR and make a new one with the one line change. |
|
That would be great thank you. |
Description:
Fixed formatting for "owner_status" in language files that contained it. There was no colon or space after "Owner" in /towny map hud.
New Nodes/Commands/ConfigOptions:
NA
Relevant Towny Issue ticket:
NA
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.