Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker and Vagrant support #123

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Remove docker and Vagrant support #123

merged 1 commit into from
Apr 3, 2020

Conversation

Toxantron
Copy link
Owner

There were lots of complaints about docker and the image was fairly old. I am glad @chrisns has volunteered to maintain the docker image in the future.

@Toxantron Toxantron merged commit 4f4b498 into dev Apr 3, 2020
@Toxantron Toxantron deleted the remove/docker branch April 3, 2020 06:02
@DewaldDeJager
Copy link

@Toxantron Any activity on this? It looks like @chrisns may have made a hard fork with no intention of merging back here. I say this because he's squashed most commits, licensed it to himself and made a lot of other changes: https://github.com/chrisns/scrumonline

If you'd like Docker support in this project and want a volunteer, I'm more than happy to help. Just don't want to do duplicate work.

@DewaldDeJager
Copy link

Ah, I see what's happened. The work has been done but in a completely separate repo with this as a submodule. It's not ideal but I guess it works.

@chrisns
Copy link

chrisns commented Apr 30, 2020

hey @DewaldDeJager, yeah the submodule was a gross hack, but it means @dependabot keeps it current and rebuilds the container for me so that its always current with this repo

@chrisns
Copy link

chrisns commented Apr 30, 2020

but yeah, not a fork, and I probably should have named the repo something better, but it got linked to and I didn't want to 404 those.
sorry for any confusion caused

@Monpoke
Copy link

Monpoke commented May 14, 2020

Hello, I made a Helm chart from your both repositories!
I should improve it next days with persistence support and external database.

https://github.com/OS4run/helm-charts/tree/master/charts/scrumonline

Tell me what do you think about it. :-)

@chrisns
Copy link

chrisns commented May 14, 2020

hey @Monpoke looks great, feel free to pr my repo if you like? happy to add you as a contributor to keep docker and k8s stuff in place. I still need to get round to documenting the knative bodge I did to run it in google cloud run

thoughts on the template itself, if you're running it properly in k8s, it'd be good to separate out the mysql into a statefulset and service and back it with a pvc, or if you don't want to bother with that, fix the replica count at 1 since anything more is going to lead to an undesirable split of traffic between where the data is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants