Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSFamily property to deployment examples #512

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Dec 19, 2023

This change is Reviewable

Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@MarcusSorealheis +@allada

Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @allada and @MarcusSorealheis)

@aaronmondal aaronmondal force-pushed the add-osfamily branch 2 times, most recently from 4134360 to 0b7108b Compare December 19, 2023 06:39
Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)


deployment-examples/terraform/AWS/scripts/scheduler.json line 114 at r2 (raw file):

        "supported_platform_properties": {
          "cpu_count": "minimum",
          "cpu_arch": "exact",

nit: change this back.


deployment-examples/terraform/AWS/scripts/scheduler.json line 116 at r2 (raw file):

          "cpu_arch": "exact",
          "memory_kb": "minimum",
          "kernel_version": "exact",

nit: Change this back.

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)

a discussion (no related file):
Need to add the same config to worker.json


Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)

a discussion (no related file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

Need to add the same config to worker.json

you may need to make it lower case. I don't remember, but it's possible that the case matters.


Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @allada and @MarcusSorealheis)

a discussion (no related file):

Previously, allada (Nathan (Blaise) Bruer) wrote…

you may need to make it lower case. I don't remember, but it's possible that the case matters.

Done.


Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)

Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)

@aaronmondal aaronmondal merged commit b6b8252 into TraceMachina:main Dec 19, 2023
19 of 20 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants