-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OSFamily property to deployment examples #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @allada and @MarcusSorealheis)
4134360
to
0b7108b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)
deployment-examples/terraform/AWS/scripts/scheduler.json
line 114 at r2 (raw file):
"supported_platform_properties": { "cpu_count": "minimum", "cpu_arch": "exact",
nit: change this back.
deployment-examples/terraform/AWS/scripts/scheduler.json
line 116 at r2 (raw file):
"cpu_arch": "exact", "memory_kb": "minimum", "kernel_version": "exact",
nit: Change this back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)
a discussion (no related file):
Need to add the same config to worker.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aaronmondal and @MarcusSorealheis)
a discussion (no related file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
Need to add the same config to
worker.json
you may need to make it lower case. I don't remember, but it's possible that the case matters.
0b7108b
to
7c13547
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 7 files reviewed, 1 unresolved discussion (waiting on @allada and @MarcusSorealheis)
a discussion (no related file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
you may need to make it lower case. I don't remember, but it's possible that the case matters.
Done.
7c13547
to
853daa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarcusSorealheis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @MarcusSorealheis)
This change is