Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Zig cc toolchains #694

Closed
aaronmondal opened this issue Mar 3, 2024 · 0 comments · Fixed by #876
Closed

Remove Zig cc toolchains #694

aaronmondal opened this issue Mar 3, 2024 · 0 comments · Fixed by #876
Assignees
@aaronmondal
Labels
bug Something isn't working

Comments

@aaronmondal
Copy link
Member

@aaronmondal aaronmondal added the bug Something isn't working label Mar 3, 2024
@aaronmondal aaronmondal self-assigned this Mar 3, 2024
@MarcusSorealheis MarcusSorealheis changed the title Zig toolchains prevent cc update Remove Zig cc toolchains Mar 16, 2024
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Apr 23, 2024
@aaronmondal
Achieve perfect reproducibility for dev setups
f988d53 
This commit changes the default C++ toolchain to the custom nix-backed
clang toolchain.

- Update custom stdenv to use Clang/LLVM 18
- Regenerate LRE toolchains.
- Remove obsolete zig_cc toolchain
- Expand LRE CI to build C++ parts of NativeLink remotely in K8s and the
  rest of rules_rust locally.

Fixes TraceMachina#694
Closes TraceMachina#477
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Apr 23, 2024
@aaronmondal
Achieve perfect reproducibility for dev setups
6bf164a 
This commit changes the default C++ toolchain to the custom nix-backed
clang toolchain.

- Update custom stdenv to use Clang/LLVM 18
- Regenerate LRE toolchains.
- Remove obsolete zig_cc toolchain
- Expand LRE CI to build C++ parts of NativeLink remotely in K8s and the
  rest of rules_rust locally.

Fixes TraceMachina#694
Closes TraceMachina#477
@aaronmondal aaronmondal mentioned this issue Apr 23, 2024
Closed
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Apr 23, 2024
@aaronmondal
Achieve perfect reproducibility for dev setups
48f3f37 
This commit changes the default C++ toolchain to the custom nix-backed
clang toolchain.

- Update custom stdenv to use Clang/LLVM 18
- Regenerate LRE toolchains.
- Remove obsolete zig_cc toolchain
- Expand LRE CI to build C++ parts of NativeLink remotely in K8s and the
  rest of rules_rust locally.

Fixes TraceMachina#694
Closes TraceMachina#477
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Apr 23, 2024
@aaronmondal
Achieve perfect reproducibility for dev setups
2739656 
This commit changes the default C++ toolchain to the custom nix-backed
clang toolchain.

- Update custom stdenv to use Clang/LLVM 18
- Regenerate LRE toolchains.
- Remove obsolete zig_cc toolchain
- Expand LRE CI to build C++ parts of NativeLink remotely in K8s and the
  rest of rules_rust locally.

Fixes TraceMachina#694
Closes TraceMachina#477
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Apr 24, 2024
@aaronmondal
Remove zig-cc
899feb3 
The zig-cc toolchain blocks updating the `cc` crate, which in turn
blocks updating a bunch of other crates. We originally had it for
backwards compatibility on older systems. Now that NativeLink's
production builds are statically linked against musl this build has
become obsolete.

Closes TraceMachina#694
@aaronmondal aaronmondal mentioned this issue Apr 24, 2024
Merged
aaronmondal added a commit that referenced this issue Apr 24, 2024
@aaronmondal
Remove zig-cc (#876)
402f335 
The zig-cc toolchain blocks updating the `cc` crate, which in turn
blocks updating a bunch of other crates. We originally had it for
backwards compatibility on older systems. Now that NativeLink's
production builds are statically linked against musl this build has
become obsolete.

Closes #694
chinchaun pushed a commit to chinchaun/nativelink that referenced this issue May 6, 2024
@aaronmondal @chinchaun
Remove zig-cc (TraceMachina#876)
7214bb4 
The zig-cc toolchain blocks updating the `cc` crate, which in turn
blocks updating a bunch of other crates. We originally had it for
backwards compatibility on older systems. Now that NativeLink's
production builds are statically linked against musl this build has
become obsolete.

Closes TraceMachina#694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronmondal aaronmondal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@aaronmondal