Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak manual rustfmt invocations via Bazel #617

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Unbreak manual rustfmt invocations via Bazel #617

merged 1 commit into from
Jan 18, 2024

Conversation

aaronmondal
Copy link
Member

@aaronmondal aaronmondal commented Jan 18, 2024 •
edited
Loading

Fixes #618

This change is Reviewable

@vercel Vercel
Copy link

vercel bot commented Jan 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nativelink-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 1:07pm

aaronmondal
aaronmondal commented Jan 18, 2024
View reviewed changes
Copy link
Member Author

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@adam-singer +@allada

Reviewable status: 0 of 2 LGTMs obtained, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / ubuntu-22.04, Cargo Dev / ubuntu-22.04, Local / ubuntu-22.04, Remote / large-ubuntu-22.04, Vercel, asan / ubuntu-22.04, docker-compose-compiles-nativelink (20.04), docker-compose-compiles-nativelink (22.04), integration-tests (20.04), integration-tests (22.04), pre-commit-checks, publish-image, ubuntu-20.04, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @adam-singer and @allada)

@aaronmondal aaronmondal linked an issue Jan 18, 2024 that may be closed by this pull request
Manual rustfmt invocations panic #618
Closed
allada
allada approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@allada allada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and pending CI: Remote / large-ubuntu-22.04 (waiting on @adam-singer)

@aaronmondal aaronmondal merged commit f39e275 into TraceMachina:main Jan 18, 2024
22 checks passed
adam-singer
adam-singer reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@adam-singer adam-singer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-singer adam-singer adam-singer left review comments

@allada allada allada approved these changes

Assignees

@allada allada

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual rustfmt invocations panic
3 participants
@aaronmondal @adam-singer @allada