Append sdkName and sdkVersion to transak url #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prajwal-Kamboj
force-pushed
the
prajwal/eng-9407-append-sdkname-and-sdkversion-from-transak-sdk-to-customer
branch
2 times, most recently
from
c76a5cb
to
4a2f3a1
Compare
debajitr
reviewed
Jul 17, 2024
|
|
||
| export function generateGlobalTransakUrl(configData: TransakConfig) { | ||
| const { environment = Environments.STAGING } = configData; | ||
| const queryParams = {}; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-member-access |
There was a problem hiding this comment.
Please figure out the correct way to add the import and avoid eslint disable statements
There was a problem hiding this comment.
Can you try exposing this via tsup env variable
|
Plz change commit message to |
Prajwal-Kamboj
force-pushed
the
prajwal/eng-9407-append-sdkname-and-sdkversion-from-transak-sdk-to-customer
branch
from
4a2f3a1
to
7371637
Compare
Co-authored-by: debajitr <debajit@transak.com>
debajitr
force-pushed
the
prajwal/eng-9407-append-sdkname-and-sdkversion-from-transak-sdk-to-customer
branch
from
7371637
to
a60e3e2
Compare
|
@Prajwal-Kamboj have updated the PR to take care of the lint issues. Please test and confirm. |
Prajwal-Kamboj
changed the title
debajitr
approved these changes
Jul 23, 2024
debajitr
deleted the
prajwal/eng-9407-append-sdkname-and-sdkversion-from-transak-sdk-to-customer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.