Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List File S3 #1075

Merged
merged 2 commits into from
Aug 17, 2023
Merged

List File S3 #1075

merged 2 commits into from
Aug 17, 2023

Conversation

luciferlinx101
Copy link
Collaborator

@luciferlinx101 luciferlinx101 commented Aug 17, 2023

Description

Fix for list file with S3 storage type

Related Issues

Solution and Design

I have fixed the working of List File Tool in case of S3 storage type

Test Plan

Use List File Tool with S3 File type.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 60.86% and project coverage change: +0.03% 🎉

Comparison is base (3f55790) 58.37% compared to head (ee55146) 58.40%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
+ Coverage   58.37%   58.40%   +0.03%     
==========================================
  Files         205      205              
  Lines        9503     9516      +13     
  Branches     1004     1007       +3     
==========================================
+ Hits         5547     5558      +11     
- Misses       3693     3694       +1     
- Partials      263      264       +1     
Files Changed Coverage Δ
superagi/tools/file/list_files.py 81.25% <60.00%> (-3.94%) ⬇️
superagi/helper/s3_helper.py 77.77% <61.11%> (+2.43%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luciferlinx101 luciferlinx101 merged commit 3d5c8fe into main Aug 17, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants