Toolkit update #937
Merged
Toolkit update #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #937 +/- ##
==========================================
- Coverage 57.84% 57.41% -0.43%
==========================================
Files 176 176
Lines 7448 7533 +85
Branches 769 794 +25
==========================================
+ Hits 4308 4325 +17
- Misses 2970 3040 +70
+ Partials 170 168 -2
☔ View full report in Codecov by Sentry. |
nihiragarwal24
requested changes
Aug 2, 2023
gui/pages/api/DashboardService.js
Outdated
Comment on lines
171
to
182
| export const updateMarketplaceToolTemplate = (templateName) => { | ||
| return api.get(`/toolkits/check_update/${templateName}`); | ||
| }; | ||
|
|
||
| export const installToolkitTemplate = (templateName) => { | ||
| return api.get(`/toolkits/get/install/${templateName}`); | ||
| }; | ||
|
|
||
| export const checkToolkitUpdate = (templateName) => { | ||
| return api.get(`/toolkits/check_update/${templateName}`); | ||
| }; | ||
|
|
There was a problem hiding this comment.
same endpoint with different functions
There was a problem hiding this comment.
fix kar diya hai, approve krdo bhai
nihiragarwal24
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prod only feature, any toolkit which is already installed and if there is change in toolkit in marketplace then now once can update their tool.
Related Issues
Solution and Design
Test Plan
Improve Code tool can be now added to user which dont have that since it is already in marketplace
Type of change
Checklist