Edit agent feature #963
Merged
Edit agent feature #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rounak Bhatia seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
superagi/models/agent_config.py
Outdated
| @classmethod | ||
| def update_agent_configurations_table(cls, session, agent_id: Union[int, None], updated_details: AgentRunIn): | ||
|
|
||
| if(type(agent_id)==None): |
There was a problem hiding this comment.
idu, If you are doing None check
why not
if agent_id is None:
nihiragarwal24
approved these changes
Aug 4, 2023
TransformerOptimus
pushed a commit
that referenced
this pull request
Aug 4, 2023
This reverts commit 425e94d.
TransformerOptimus
pushed a commit
that referenced
this pull request
Aug 4, 2023
minor bug resolved (#986) workflow test (#987) Edit agent feature (#963) json text area functionality for google analytics (#991) Edit agent new (#944) minor backward compatibility fixes Revert "Edit agent feature (#963)" This reverts commit 425e94d. Revert "Edit agent new (#944)" (#996) This reverts commit a9d47c1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes in 6 files:
controllers/agent.py -> removed the fetch details api and i have moved it to the controllers/agent_execution_config.py file
and in the create_agent_with_config function i have added new agent_execution_configs
models/agent_config.py -> added a update_agent_configurations_table function which updates the "agent_configurations" table
whenever we run edit agent
controllers/agent_execution_config.py -> added a new api call(get_agent_execution_configuration) , which is used by frontend to fetch the details of the execution/ run
controllers/ agent_execution.py -> added a new api call(create_agent_run), which is used to create a new execution/ run
controllers/ type/ agent_execution_config.py -> created this new file which contains the AgentRunIn class, this class is used to update the "agent_configurations" table and to create a new execution
models/agent.py -> using this code for extracting value:
list(ast.literal_eval(value))
because the array containing the tools_id is received in the form of a string
Related Issues
Solution and Design
Test Plan
Type of change
Checklist