d3d12: Use Device10 Placed/CommittedResource functions for Enhanced-Barriers initial Layout
#168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manon-traverse
approved these changes
May 16, 2023
Seems the CI did not run on that PR, or at least didn't obstruct merging said PR.
…ed-Barriers initial Layout When using enhanced barriers new resource creation APIs need to be used to set its initial layout rather than setting an initial state, which is the legacy enumeration API. In order to support this we need access to `Device10` where the new methods reside, which we could query (`.cast()`) from `ID3D12Device` or request from the user directly as done here.
MarijnS95
force-pushed
the
dx12-device10-eb-layout
branch
from
58b80fc to
d51f58d
Compare
MarijnS95
added a commit
that referenced
this pull request
May 16, 2023
The CI isn't holding back PR merges, and some nitty API changes behind feature toggles slipped through the cracks.
MarijnS95
added a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using enhanced barriers new resource creation APIs need to be used to set its initial layout rather than setting an initial state, which is the legacy enumeration API.
In order to support this we need access to
Device10where the new methods reside, which we could query (.cast()) fromID3D12Deviceor request from the user directly as done here.