-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍎 Add Metal implementation #199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlannyH
force-pushed
the
metal-support
branch
2 times, most recently
from
February 13, 2024 11:13
58a838d
to
b44a3ee
Compare
FlannyH
force-pushed
the
metal-support
branch
from
February 20, 2024 14:13
b44a3ee
to
d630c1b
Compare
FlannyH
force-pushed
the
metal-support
branch
from
February 21, 2024 13:07
12f8e81
to
65f3236
Compare
Use this function in `encoder.use_heaps(gpu_allocator.get_heaps())`
Similar to how the Vulkan implementation does it
I wasn't sure about this change, so I'm reverting it for now
FlannyH
force-pushed
the
metal-support
branch
from
February 22, 2024 10:11
65f3236
to
5788bb4
Compare
manon-traverse
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements gpu-allocator for the Metal API. This PR does not implement the visualizer, as I'm currently unable to test that on Metal