👨🔬Total memory in Allocation Breakdown #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper-Bekkers
force-pushed
the
add-total
branch
from
a584985 to
34166df
Compare
tosti007
reviewed
Feb 21, 2024
src/visualizer/allocation_reports.rs
Outdated
|
|
||
| let row_height = ui.text_style_height(&egui::TextStyle::Body); | ||
| ui.horizontal(|ui| { |
There was a problem hiding this comment.
Nit: there's only a single label in here, so the horizontal isn't needed.
tosti007
approved these changes
Mar 1, 2024
auto-merge was automatically disabled
March 1, 2024 15:12
Head branch was modified
Jasper-Bekkers
force-pushed
the
add-total
branch
from
9ccd581 to
31e326c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had this feature previously but it got nerf'd during our transition from egui to imgui. It's small but super useful to be able to see the total amount of memory under various filters (or just the total when no filter is applied).