🧼 Clean up Metal implementation #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper-Bekkers
approved these changes
May 22, 2024
MarijnS95
reviewed
Jun 7, 2024
There was a problem hiding this comment.
Other cleanups you could do (that's not visible in the diff):
- Remove functions that always panic via
todo!(); - Change
heap_types.iter()inAllocator::new()tointo_iter(), so that you can removeheap_descriptor.clone(); - Remove
_sizefromMemoryBlockif it's never read and not public?
MarijnS95
approved these changes
Jun 12, 2024
commit b1407d5 Author: Marijn Suijten <marijn@traverseresearch.nl> Date: Wed Jun 12 14:34:30 2024 +0200 metal: Use our own `MemoryLocation` for `MTLHeap` (`MemoryBlock`) labels commit 91a839d Author: Marijn Suijten <marijn@traverseresearch.nl> Date: Wed Jun 12 14:32:38 2024 +0200 metal: Delete strange copy-paste functions that always panic via `todo!()` Since we're not implementing `trait`s here (every backend just "looks" the same but is different because of heavy API coupling), we shouldn't have a bunch of dead `todo!()` unimplemented functions publicly exposed. commit 8182a39 Merge: c812c08 95ba6d0 Author: Marijn Suijten <marijn@traverseresearch.nl> Date: Wed Jun 12 12:47:19 2024 +0200 Merge remote-tracking branch 'origin/main' into metal-clean commit c812c08 Author: Marijn Suijten <marijn@traverseresearch.nl> Date: Wed Jun 12 10:15:56 2024 +0200 Remove clone commit 0a943ea Author: Lily Haverlag <flannyha@gmail.com> Date: Wed May 22 12:19:04 2024 +0200 Add white lines commit 465713f Author: Lily Haverlag <flannyha@gmail.com> Date: Wed May 22 12:18:36 2024 +0200 Remove unused empty structs commit d809208 Author: Lily Haverlag <flannyha@gmail.com> Date: Wed May 22 12:18:26 2024 +0200 Improve debug label for memory blocks commit 33e8ae0 Author: Lily Haverlag <flannyha@gmail.com> Date: Wed May 22 12:18:13 2024 +0200 Add debug derives
|
Really curious why automerge pulled in the PR even before the CI run completed. If failed after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[derive()]s consistent with the Dx12 implementation