cargo: Replace metal-rs
patch with git
dependency
#228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gpu-allocator
is a library crate, meaning that[patch]
es don't get applied when users depend on our crate, and falsely end up with a broken build while our CI said everything was hunky dory ( #224). Even though we cannot normally have a directgit
dependency as that blocks us from publishing to crates.io, the currentgpu-allocator
release (though only for Metal) is broken anyway. It's relying on functionality that has just now been merged upstream, but still has to make it into a (followup patch) release.What's worse, the harcoded hash that this was pointing to no longer has a live reference on our fork (maybe due to a force-push), and the CI is now failing to to fetch that commit by hash while build-testing
gpu-allocator
.Let's bump to a
git
dependency for now, and replace that as soon as we have a workable solution, however that pans out.