Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: Update to DXC's null-invariant BSTR #11

Merged
merged 1 commit into from
May 5, 2021
Merged

Linux: Update to DXC's null-invariant BSTR #11

merged 1 commit into from
May 5, 2021

Commits on May 5, 2021

  1. Linux: DXC BSTR now resembles its Windows counterpart with explicit size 

    We [recently] fixed memory leaks when calling into the intellisense part
of DXC and made the decision shortly after merging to [implement
null-invariant `BSTR`s properly] in DXC's shimmed type for non-Windows,
which was promptly accepted.

Currently our implementation of `SysFreeString` together with that PR
segfaults because it frees the pointer at offset `+4` of the allocation.
That is corrected together with `SysStringLen` now reading the size of
the string from this prefix instead of looking for a (wrong!) null
termination character.  At least our Windows and Linux implementation
`utils.rs` is the same again.

[recently]: #10
[implement null-invariant `BSTR`s properly]: microsoft/DirectXShaderCompiler#3250
    @MarijnS95
    MarijnS95 committed May 5, 2021
    Configuration menu
    Copy the full SHA
    8edb988 View commit details
    Browse the repository at this point in the history