🖖Add fake dxil signing support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Jan 11, 2022
| pub struct Context { | ||
| buffer: [u8; 64], | ||
| count: [u32; 2], | ||
| pub state: [u32; 4], // hassle-rs modification |
There was a problem hiding this comment.
Would it make sense to PR this back? Also, maybe a short overview of the crate mod(s?) at the top of the file in a comment would be nice :)
There was a problem hiding this comment.
I thought about it, but the crate didn't have any updates since 2019 and doesn't seem very active. However it is quite widely used. We can PR it back since this is the only real mod that we require. Did it like this for now because I don't want a git dependency here (since we can't push a release then).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds helper functions to sign dxil blobs without needing the
dxil.dllpresent in the code repository. The code is a straight port from RenderDoc that has similar functionality.