Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/fake-signing: Make runnable on Linux #26

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Jan 12, 2022

The main reason for fake signing is making it run on Linux - and not depend on dxil.dll on Windows - so it's great if this example runs on Linux as well to see it all working even if that requires a few nasty cfg blocks. Note that this is done with cfg!() and regular if blocks instead of attributes, such that this code lints and compiles on both Windows and Linux even if the validate_dxil() codepath is never entered on the latter (and that way includes, let mut all_matches etc don't need to be #[cfg(windows)]'ed out either).


Creating as draft because:

The main reason for fake signing is making it run on Linux - and not
depend on `dxil.dll` on Windows - so it's great if this example runs on
Linux as well to see it all working even if that requires a few nasty
cfg blocks.  Note that this is done with `cfg!()` and regular `if`
blocks instead of attributes, such that this code lints and compiles on
both Windows and Linux even if the `validate_dxil()` codepath is never
entered on the latter (and that way includes, `let mut all_matches` etc
don't need to be `#[cfg(windows)]`'ed out either).
@Jasper-Bekkers Jasper-Bekkers merged commit 5335634 into main Jan 31, 2022
@MarijnS95 MarijnS95 deleted the fake-signing-linux branch January 31, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants