Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently return HassleError and remove unneeded check macros #30

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Consistently return HassleError and remove unneeded check macros #30

merged 1 commit into from
Jan 25, 2022

Commits on Jan 25, 2022

  1. Consistently return HassleError and remove unneeded check macros 

    Our public API becomes a lot cleaner when returning `HassleError`
everywhere, helped by the fact that `HRESULT`s from the low-level COM
API is a newtype with support for functions to convert to `Result<>`
easily.  These can be short-circuit-returned in a more Rust'y way
through the questionmark operator instead of wrapping everything in
large macro calls.  This change is based on a similar approach in the
Ash crate: https://github.com/MaikKlein/ash/pull/339/files
    @MarijnS95
    MarijnS95 committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    bfc7f90 View commit details
    Browse the repository at this point in the history