Migrate to Microsoft's com-rs #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 31, 2022
MarijnS95
commented
Feb 1, 2022
MarijnS95
commented
Feb 1, 2022
MarijnS95
commented
Feb 1, 2022
|
We won't be merging this as Will leave this open until that's all done and we can start the migration process again, will likely use this PR as a base for it. |
The `com-rs` crate is deprecated, but Microsoft published their vetted and maintained replacement as `com`. This crate has much better helpers and doesn't pull in the `libuuid` library that isn't available on Android nor Mac. Unfortunately there is still no verdict how this crate relates to the windows-rs iniative, where the entire FFI API is autogenerated from metadata, nor has it been possible to bring in Linux support thus far. As such we'll stick with Microsoft's `com` for now which is already a step in the right direction. Note that we'll have to figure out a cleaner solution to get a stack-allocated, temporary class allocation for the include handler: one that is only allowed to live as long as the surrounding function, instead of endlessly on the heap.
|
I'm fine merging this now. Even though |
Jasper-Bekkers
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23, fixes #28, closes #36
The
com-rscrate is deprecated, but Microsoft published their vetted and maintained replacement ascom. This crate has much better helpers and doesn't pull in thelibuuidlibrary that isn't available on Android nor Mac.Unfortunately there is still no verdict how this crate relates to the windows-rs iniative, where the entire FFI API is autogenerated from metadata, nor has it been possible to bring in Linux support thus far. As such we'll stick with Microsoft's
comfor now which is already a step in the right direction.Note that we'll have to figure out a cleaner solution to get a stack-allocated, temporary class allocation for the include handler: one that is only allowed to live as long as the surrounding function, instead of endlessly on the heap.