Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in contributions section #39

Merged
merged 1 commit into from
May 19, 2022
Merged

Fix typo in contributions section #39

merged 1 commit into from
May 19, 2022

Conversation

janie177
Copy link
Member

Contributions instead of Contibutions.

`Contributions` instead of `Contibutions`.
Copy link

@hannes-vernooij hannes-vernooij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@MarijnS95
Copy link
Member

MarijnS95 commented Apr 25, 2022

error: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
Error:    --> src/wrapper.rs:1[9](https://github.com/Traverse-Research/hassle-rs/runs/6155503861?check_suite_focus=true#step:7:9)8:22
    |
198 |         dxc_defines: &mut Vec<DxcDefine>,
    |                      ^^^^^^^^^^^^^^^^^^^ help: change this to: `&mut [DxcDefine]`
    |
    = note: `-D clippy::ptr-arg` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

This looks to be a false-positive of Rust 1.60 and is gone in the next beta, as we call Vec::push on dxc_defines and you can't call that on (mutable) slices...

@MarijnS95
Copy link
Member

@janie177 Let's go get this in after #41 :)

@MarijnS95 MarijnS95 merged commit aeb16c5 into main May 19, 2022
@MarijnS95 MarijnS95 deleted the typo-in-readme branch May 19, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants