Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Revert "[WIN/LINUX] Implement vtable dummies (virtual dtors) through extra trait" #50

Merged
merged 3 commits into from
Dec 17, 2022

Commits on Nov 9, 2022

  1. Revert "[WIN/LINUX] Implement vtable dummies (virtual dtors) through …

    …extra trait"
    
    This reverts commit c37cb03. [This
    commit] is squashed in the merge of PR #5, and does not exist in-tree.
    
    microsoft/DirectXShaderCompiler#3793 has finally
    been merged on October 13th 2022 and now allows us to drop the vtable
    dummies for virtual destructors again, as those are not part of the ABI
    and shouldn't have been in the vtable in the first place.
    
    [This commit]: c37cb03
    MarijnS95 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    cb1299f View commit details
    Browse the repository at this point in the history
  2. README: Replace verbose compatibility "guide" with direct table

    It's been quite a while ago (about two years) since we landed a whole
    bunch of compatibility fixes for DXC, and I hope everyone is using
    (much) newer releases by now.  I also doubt anyone is interested in
    detailed descriptions of what we fixed (including the how and why), and
    just wants a clear answer on the DXC release or commit they must
    minimally use for compatibility with a certain `hassle-rs` release.
    MarijnS95 committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    d626576 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Configuration menu
    Copy the full SHA
    30c0821 View commit details
    Browse the repository at this point in the history