Implement custom Drop for IRVersionedCSInfo
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosti007
approved these changes
Aug 2, 2024
Every `IRVersioned*Info` structure has an accompanying `IRShaderReflectionRelease*Info()` function to clean up allocated pointers inside, mostly strings. Even though `IRVersionedCSInfo` doesn't contain any pointers, it is a versioned structure that could be extended in the future with allocated objects, so we should call the existing (currently no-op) `Release` function on it prematurely.
MarijnS95
force-pushed
the
drop-versioned-cs-info
branch
from
a0ef24b to
dda00cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every
IRVersioned*Infostructure has an accompanyingIRShaderReflectionRelease*Info()function to clean up allocated pointers inside, mostly strings. Even thoughIRVersionedCSInfodoesn't contain any pointers, it is a versioned structure that could be extended in the future with allocated objects, so we should call the existing (currently no-op)Releasefunction on it prematurely.