Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ehancing checks around auth headers #2

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

chris-treblle
Copy link
Contributor

This enhances the tasks by checking if the count is greater than or equal to 2, then looping all but the first, if not making the first anyway.

Tests added to ensure stability.

Copy link
Member

@cindreta cindreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out to me

Copy link
Contributor

@JustSteveKing JustSteveKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks @chris-treblle

@chris-treblle chris-treblle merged commit efe56a8 into main Aug 30, 2023
4 checks passed
@chris-treblle chris-treblle deleted the feature/manage-more-complex-auth branch August 30, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants