Feature/next #6
Open
Feature/next #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoka123
reviewed
Mar 27, 2023
zoka123
reviewed
Mar 27, 2023
| "php": "^8.1", | ||
| "php-http/client-common": "^2.6", | ||
| "php-http/discovery": "^1.15.2", | ||
| "php-http/mock-client": "^1.5", |
There was a problem hiding this comment.
Is this maybe a dev dependency (assuming it's only used in tests)
There was a problem hiding this comment.
The mock-client is only used in tests, but the others are used in the actual code type hinted - but also used for autodiscovery of libraries suitable
There was a problem hiding this comment.
We could move php-http/mock-client to require-dev section if it's only used in tests to avoid installing it for projects?
zoka123
reviewed
Mar 27, 2023
zoka123
reviewed
Mar 27, 2023
| </testsuites> | ||
| <coverage> | ||
| <include> | ||
| <directory suffix=".php">./app</directory> |
There was a problem hiding this comment.
Is there a plan for this dir to be added? Can't find it now so maybe it's a leftover
There was a problem hiding this comment.
Yeah this should be removed!
Co-authored-by: Zoran Antolović <zoran.antolovic.os@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduced the next stable release, utilising PSR standards and as much flexibility as possible.
Some logic has been abstracted to another package to reduce code duplication.