Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update spring-boot to latest & add Gradle package manager #4

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ayewo
Copy link

@ayewo ayewo commented Jan 17, 2024

This PR includes the following updates:

  • updates the Treblle SDK to use the latest version of Spring Boot (3.2.1);
  • bumps the Treblle SDK version from 2.0.0 to 2.1.0;
  • adds another package manager (Gradle) alongside the existing package manager (Maven).

@JustSteveKing Please take a look when you have a moment.

@cindreta
Copy link
Member

Hey @ayewo thx so much for making the PR. @IvoMajic Is gonna review and merge 🔥

@IvoMajic
Copy link
Collaborator

Everything seems fine in terms of bumping Spring...except for the Gradle addition, I do not see a point unless the project switches the whole Sonatype publishing to it (maintaining two build systems is not the goal)

@ayewo
Copy link
Author

ayewo commented Jan 21, 2024

@IvoMajic

Thanks for finally taking a look.

  1. Should I remove the Gradle addition then?
  2. Will this https://github.com/Treblle/springboot-api-boilerplate also need updating to use the updated Spring Boot and Treblle SDK?

@IvoMajic
Copy link
Collaborator

Yes, you can remove the Gradle stuff and leave just the Spring upgrade. That can then go as a minor version bump eg. 2.1.0. The boilerplate decision I leave to @cindreta

@ayewo
Copy link
Author

ayewo commented Jan 22, 2024

@IvoMajic this is ready for review.

@cindreta can you please comment if you'd like to also update the code in the https://github.com/Treblle/springboot-api-boilerplate repo?

Thanks

@ayewo
Copy link
Author

ayewo commented Jan 29, 2024

@IvoMajic have you had a chance to look?

@cindreta waiting on your answer this?

@JustSteveKing
Copy link
Contributor

@cindreta could we get some movement on this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants