Fixed group array mutation on call to validator middleware
#274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…every call to the middleware function, causing a "memory leak" in a sense. The bug was a result of the admin role being pushed to the `group` array every time an endpoint using that particular validator was invoked. The fix for this was to move these operations outside the closure, since they really only need to be executed once. This bug isn't particularly dangerous on face level, but if someone were to spam the API then the server could potentially start running out of memory. Reproducing the bug from an account without proper authorization to use an endpoint: ``` $ curl 'https://root.treehacks.com/api/judges' ... Unauthorized; user is not in group admin,admin,admin,admin,admin,admin,admin,admin,admin,admin,admin,admin.% $ curl 'https://root.treehacks.com/api/judges' ... Unauthorized; user is not in group admin,admin,admin,admin,admin,admin,admin,admin,admin,admin,admin,admin,admin.% ``` Notice how the number of `admin`s gets a bit longer? That doesn't look right 🧐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where global variable in
validateGroupwas mutated after every call to the middleware function, causing a "memory leak" in a sense.The bug was a result of the admin role being pushed to the
grouparray every time an endpoint using that particular validator was invoked. The fix for this was to move these operations outside the closure, since they really only need to be executed once.This bug isn't particularly dangerous on face level, but if someone were to spam the API then the server could potentially start running out of memory.
Reproducing the bug from an account without proper authorization to use an endpoint:
Notice how the number of
admins gets a bit longer? That doesn't look right 🧐Another cool example:
Yeah, that's a lot of admins 😅