Application form save data bug fix #285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Changed target branch to most recent and active branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered a bug on the application portal where when I tried to save my progress I had an infinite loading status.
The network tab revealed that there was a 401 status code. So if a users auth expires before they try saving they can't save and infinitely see a loading screen.
The
saveData()function insrc/store/form/actions.tswas the only api call without a.catch()statement. I added the catch statement in the same style as the rest of the file. Then I removed redundant calls todispatch(loadingEnd())by moving it too a.final()statement.Note:
I don't have a
.envfile so my changes are untested. It would be great to see an example.envfile listed in theREADMEso contributors can test code. I checked the wiki and usedfind . env | grep envbut I didn't find any env related files. Maybe I missed it.Happy hacking!