Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): do not show popover if there are no options #803

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(select): do not show popover if there are no options #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/components/select/bl-select.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ describe("bl-select", () => {
});

it("renders with default values", async () => {
const el = await fixture<BlSelect>(html`<bl-select></bl-select>`);
const el = await fixture<BlSelect>(html`<bl-select>
<bl-select-option value="1">Option 1</bl-select-option>
</bl-select>`);

assert.shadowDom.equal(
el,
Expand Down Expand Up @@ -68,6 +70,12 @@ describe("bl-select", () => {
expect(helpMessage).to.exist;
expect(helpMessage?.innerText).to.equal(helpText);
});
it("should not show popover if there is no option", async () => {
const el = await fixture<BlSelect>(html`<bl-select></bl-select>`);
const popover = el.shadowRoot?.querySelector(".popover");

expect(popover).to.not.exist;
});
it("should render bl-select-options", async () => {
const el = await fixture<BlSelect>(html`<bl-select>
<bl-select-option value="1">Option 1</bl-select-option>
Expand Down Expand Up @@ -117,7 +125,7 @@ describe("bl-select", () => {
expect(selectedOptions?.textContent).contains("Option 3");
});
it("should open select menu", async () => {
const el = await fixture<BlSelect>(html`<bl-select>button</bl-select>`);
const el = await fixture<BlSelect>(html`<bl-select><bl-select-option value="1">Option 1</bl-select-option></bl-select>`);

const selectInput = el.shadowRoot?.querySelector<HTMLDivElement>(".select-input");

Expand All @@ -126,7 +134,7 @@ describe("bl-select", () => {
expect(el.opened).to.true;
});
it("should close select menu", async () => {
const el = await fixture<BlSelect>(html`<bl-select>button</bl-select>`);
const el = await fixture<BlSelect>(html`<bl-select><bl-select-option value="1">Option 1</bl-select-option></bl-select>`);

const selectInput = el.shadowRoot?.querySelector<HTMLDivElement>(".select-input");

Expand All @@ -137,7 +145,7 @@ describe("bl-select", () => {
});
it("should close select menu when click outside & run validations", async () => {
const el = await fixture<BlSelect>(html`<body>
<bl-select required invalid-text="This field is mandatory"></bl-select>
<bl-select required invalid-text="This field is mandatory"><bl-select-option value="1">Option 1</bl-select-option></bl-select>
</body>`);

const selectInput = el.shadowRoot?.querySelector<HTMLDivElement>(".select-input");
Expand Down
52 changes: 27 additions & 25 deletions src/components/select/bl-select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,31 +534,33 @@ export default class BlSelect<ValueType extends FormValue = string> extends Form
@keydown=${this.handleKeydown}
>
${label} ${this.inputTemplate()}
<div
class="popover"
tabindex="${ifDefined(this._isPopoverOpen ? undefined : "-1")}"
@bl-select-option=${this._handleSelectOptionEvent}
role="listbox"
aria-multiselectable="${this.multiple}"
aria-labelledby="label"
>
${this.selectAllTemplate()}
<slot></slot>
${this.searchBar && this.noResultFound
? html`<div name="popover-clear-search-text" class="popover-no-result">
<span>${noDataText}</span>
<bl-button
variant="tertiary"
@click=${() => {
this._handleSearchOptions({ target: { value: "" } } as InputEvent & {
target: HTMLInputElement;
});
}}
>${clearSearchText}</bl-button
>
</div>`
: ""}
</div>
${this.options.length > 0
? html` <div
class="popover"
tabindex="${ifDefined(this._isPopoverOpen ? undefined : "-1")}"
@bl-select-option=${this._handleSelectOptionEvent}
role="listbox"
aria-multiselectable="${this.multiple}"
aria-labelledby="label"
>
${this.selectAllTemplate()}
<slot></slot>
${this.searchBar && this.noResultFound
? html`<div name="popover-clear-search-text" class="popover-no-result">
<span>${noDataText}</span>
<bl-button
variant="tertiary"
@click=${() => {
this._handleSearchOptions({ target: { value: "" } } as InputEvent & {
target: HTMLInputElement;
});
}}
>${clearSearchText}</bl-button
>
</div>`
: ""}
</div>`
: ""}
<div class="hint">${invalidMessage} ${helpMessage}</div>
</div> `;
}
Expand Down
Loading