Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drawer): fix drawer delay bug for removing from dom #875

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

fatihkucuktry
Copy link
Contributor

Closes #536

doganozturk
doganozturk previously approved these changes May 27, 2024
Copy link
Contributor

@doganozturk doganozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure about exposing --bl-drawer-animation-duration, but this change resolves the issue. We might need to get another opinion on this.

@leventozen leventozen self-requested a review May 31, 2024 10:38
@buseselvi buseselvi merged commit 5e4ef0e into next Jun 3, 2024
7 checks passed
@buseselvi buseselvi deleted the fix-drawer-delay branch June 3, 2024 08:59
Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 3.0.0-beta.22 🎉

The release is available on:

Your semantic-release bot 📦🚀

@erbilnas erbilnas mentioned this pull request Oct 11, 2024
erbilnas added a commit that referenced this pull request Oct 11, 2024
## What's Changed
* Merge pull request #783 from Trendyol/next by @leventozen in
#784
* docs: bump version in docs by @leventozen in
#851
* docs: bump version by @leventozen in
#852
* feat(icon): add door and credit_card icons by @umitkucuk in
#855
* chore(deps-dev): bump ejs from 3.1.9 to 3.1.10 by @dependabot in
#850
* feat(select): improve option navigation by key by @gokcecicek in
#856
* fix(popover): Fix bl-tooltip trigger issue by @MertOzbudak in
#871
* feat(tooltip): add target attribute by @Enes5519 in
#848
* feat(dialog): implement critical variant by @AykutSarac in
#870
* fix(drawer): fix drawer delay bug for removing from dom by
@fatihkucuktry in #875
* fix(split-button): fix event bubbling for buttons inside split button
by @ozkersemih in #879
* fix(select): fix disabled select option can be selected with enter by
@ahmetozantekin in #874
* chore: update dependabot.yml configuration by @doganozturk in
#882
* feat(select): Improve select search international character support by
@fatihkucuktry in #857
* feat(select): fix search text is not clear bug when user click clear
button by @mozbatman in #858
* story(input): add input masking documentation by @doganozturk in
#883
* style(dialog): tab-group inside dialog by @ozkersemih in
#872
* feat(select): fix search text is not clear bug when user click clear
button by @mozbatman in #885
* fix: Use lowercase script import in using-baklava-in-next.stories.mdx
by @BerkinAKKAYA in #884
* feat: calendar component by @dilandoogan in
#823
* feat: spinner component by @MertOzbudak in
#877
* docs(ADR): move ADRs under components directories by @AykutSarac in
#865
* fix(checkbox): add relative value for position in checkbox container
by @erbilnas in #896
* chore(deps): bump actions/configure-pages from 3 to 5 by @dependabot
in #887
* chore(deps): bump actions/deploy-pages from 2 to 4 by @dependabot in
#888
* refactor(icon): implement baklava-icons and remove icons folder by
@ogunb in #898
* feat(input): prevent enter to submit form by @muratcorlu in
#691
* fix(checkbox): fix validation state of checkbox by @Enes5519 in
#904
* feat(dialog): add width and caption line clamp css property by
@Enes5519 in #902
* fix(tooltip): use mouseenter as event listener by @ozkersemih in
#909
* fix(table): multiple checkbox should only handle currently rendered
rows by @ogunb in #913
* feat(datepicker): remove calendar border by @dilandoogan in
#917
* feat(datepicker): fix selected date color bug by @dilandoogan in
#922
* fix: upgrade next version to resolve vulnerability by @erbilnas in
#929
* docs: resolve conflict in storybook by @erbilnas in
#928

## New Contributors
* @gokcecicek made their first contribution in
#856
* @MertOzbudak made their first contribution in
#871
* @fatihkucuktry made their first contribution in
#875
* @ahmetozantekin made their first contribution in
#874
* @mozbatman made their first contribution in
#858
* @dilandoogan made their first contribution in
#823

**Full Changelog**:
v3.1.0...3.2.0

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Berkin AKKAYA <berkin_akkaya@hotmail.com>
Signed-off-by: Aykut Saraç <aykutsarac0@gmail.com>
Co-authored-by: Levent Anil Ozen <leventanilozen@gmail.com>
Co-authored-by: Ümit Küçük <24843599+umitkucuk@users.noreply.github.com>
Co-authored-by: Umit Kucuk <umit.kucuk@trendyol.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Beril Gökçe Çiçek <52400850+gokcecicek@users.noreply.github.com>
Co-authored-by: ozkersemih <huseyinflash@gmail.com>
Co-authored-by: MertOzbudak <mert.zbdk@gmail.com>
Co-authored-by: mert.ozbudak <mert.ozbudak@trendyol.com>
Co-authored-by: Enes Yıldırım <enes5519@gmail.com>
Co-authored-by: Aykut Saraç <aykutsarac0@gmail.com>
Co-authored-by: Fatih Küçük <156313362+fatihkucuktry@users.noreply.github.com>
Co-authored-by: Semih Ozker <52029025+ozkersemih@users.noreply.github.com>
Co-authored-by: ahmetozantekin <ahmetozantekin@gmail.com>
Co-authored-by: Ahmet Ozan Tekin <ahmetozan.tekin@trendyol.com>
Co-authored-by: Doğan Öztürk <doganozturk2005@gmail.com>
Co-authored-by: Mustafa Özbatman <49883994+mozbatman@users.noreply.github.com>
Co-authored-by: mustafa.ozbatman <mustafa.ozbatman@trendyol.com>
Co-authored-by: Doğan Öztürk <dogan.ozturk@trendyol.com>
Co-authored-by: Ogun Babacan <ogun.babacan@trendyol.com>
Co-authored-by: Berkin AKKAYA <berkin_akkaya@hotmail.com>
Co-authored-by: dilandoogan <147757889+dilandoogan@users.noreply.github.com>
Co-authored-by: Buse Selvi <106681486+buseselvi@users.noreply.github.com>
Co-authored-by: Erbil Nas <erbil.nas@trendyol.com>
Co-authored-by: Murat Çorlu <127687+muratcorlu@users.noreply.github.com>
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawer has delay for removing from dom
5 participants