Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Transactional Retry false x-error-message bug #122

Merged
merged 14 commits into from
Mar 28, 2024

Conversation

Abdulsametileri
Copy link
Member

@Abdulsametileri Abdulsametileri commented Mar 28, 2024

Related #115

@Abdulsametileri Abdulsametileri changed the title Fix/issue nontransactional errormessage fix: Transactional Retry false x-error-message bug Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.81%. Comparing base (9ec9054) to head (b86c0af).
Report is 5 commits behind head on v2.

❗ Current head b86c0af differs from pull request most recent head 532d1a4. Consider uploading reports for the commit 532d1a4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #122      +/-   ##
==========================================
+ Coverage   41.49%   44.81%   +3.32%     
==========================================
  Files          19       19              
  Lines         723      752      +29     
==========================================
+ Hits          300      337      +37     
+ Misses        413      405       -8     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abdulsametileri
Copy link
Member Author

{"level":"DEBUG","time":"2024-03-28T18:03:06.171Z","sourceLocation":"v2@v2.1.9/consumer_base.go:122","message":"Initializing Cronsumer"}
{"level":"DEBUG","time":"2024-03-28T18:03:06.171Z","sourceLocation":"v2@v2.1.9/consumer_base.go:122","message":"Initializing Cronsumer"}
{"level":"DEBUG","time":"2024-03-28T18:03:06.171Z","sourceLocation":"v2@v2.1.9/consumer_base.go:122","message":"Initializing Cronsumer"}
{"level":"DEBUG","time":"2024-03-28T18:03:06.172Z","sourceLocation":"v2@v2.1.9/consumer_base.go:122","message":"Initializing Cronsumer"}
{"level":"DEBUG","time":"2024-03-28T18:03:06.172Z","sourceLocation":"v2@v2.1.9/consumer_base.go:122","message":"Initializing Cronsumer"}
{"level":"DEBUG","time":"2024-03-28T18:03:06.172Z","sourceLocation":"v2@v2.1.9/consumer_base.go:122","message":"Initializing Cronsumer"}

need to enhance this kind of logs messages

@dilaragorum dilaragorum merged commit f9bc1d6 into v2 Mar 28, 2024
4 checks passed
@dilaragorum dilaragorum deleted the fix/issue-nontransactional-errormessage branch March 28, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants