Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance Message Could Not Reader error by adding topic and cg info #138

Merged
merged 3 commits into from
Aug 5, 2024
Merged

feat: enhance Message Could Not Reader error by adding topic and cg info #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18a21a2
feat: enhance Message Could not read error with topic and cg
Abdulsametileri Aug 5, 2024
b47cbb7
chore: remove prefix xxx from example topic
Abdulsametileri Aug 5, 2024
76a6a0c
chore: fix lint
Abdulsametileri Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions batch_consumer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func Test_batchConsumer_startBatch(t *testing.T) {
concurrency: 1,
},
messageGroupLimit: 3,
consumeFn: func(messages []*Message) error {
consumeFn: func(_ []*Message) error {
numberOfBatch++
return nil
},
Expand Down Expand Up @@ -101,7 +101,7 @@ func Test_batchConsumer_startBatch_with_preBatch(t *testing.T) {
concurrency: 1,
},
messageGroupLimit: 2,
consumeFn: func(messages []*Message) error {
consumeFn: func(_ []*Message) error {
numberOfBatch++
return nil
},
Expand Down Expand Up @@ -179,7 +179,7 @@ func Test_batchConsumer_process(t *testing.T) {
gotOnlyOneTimeException := true
bc := batchConsumer{
base: &base{metric: &ConsumerMetric{}, transactionalRetry: true, logger: NewZapLogger(LogLevelDebug)},
consumeFn: func(messages []*Message) error {
consumeFn: func(_ []*Message) error {
if gotOnlyOneTimeException {
gotOnlyOneTimeException = false
return errors.New("simulate only one time exception")
Expand Down
5 changes: 4 additions & 1 deletion consumer_base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ type base struct {
consumerState state
metricPrefix string
mu sync.Mutex
consumerCfg *ConsumerConfig
}

func NewConsumer(cfg *ConsumerConfig) (Consumer, error) {
Expand Down Expand Up @@ -138,6 +139,7 @@ func newBase(cfg *ConsumerConfig, messageChSize int) (*base, error) {
skipMessageByHeaderFn: cfg.SkipMessageByHeaderFn,
metricPrefix: cfg.MetricPrefix,
mu: sync.Mutex{},
consumerCfg: cfg,
}

if cfg.DistributedTracingEnabled {
Expand Down Expand Up @@ -201,7 +203,8 @@ func (c *base) startConsume() {
}

c.metric.TotalErrorCountDuringFetchingMessage++
c.logger.Warnf("Message could not read, err %s", err.Error())
//nolint:lll
c.logger.Warnf("Message could not read, err %s, from topics %s with consumer group %s", err.Error(), c.consumerCfg.getTopics(), c.consumerCfg.Reader.GroupID)
continue
}

Expand Down
1 change: 1 addition & 0 deletions consumer_base_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ func Test_base_startConsume(t *testing.T) {
logger: NewZapLogger(LogLevelError),
consumerState: stateRunning,
metric: &ConsumerMetric{},
consumerCfg: &ConsumerConfig{},
}
b.context, b.cancelFn = context.WithCancel(context.Background())

Expand Down
2 changes: 1 addition & 1 deletion consumer_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestConsumerConfig_newCronsumerConfig(t *testing.T) {
// Given
cfg := ConsumerConfig{
RetryConfiguration: RetryConfiguration{
SkipMessageByHeaderFn: func(headers []Header) bool {
SkipMessageByHeaderFn: func(_ []Header) bool {
return false
},
},
Expand Down
Loading