Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change consumeFn and batchConsumeFn as pointer signature #62

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Abdulsametileri
Copy link
Member

@Abdulsametileri Abdulsametileri commented Nov 4, 2023

Users should modify the message, for example, adding a new header or removing the old one. To pass this modification to the exception topic, we need to pass the message as a pointer.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (326fc77) 31.19% compared to head (af8af57) 31.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   31.19%   31.81%   +0.61%     
==========================================
  Files          19       19              
  Lines         609      613       +4     
==========================================
+ Hits          190      195       +5     
+ Misses        413      412       -1     
  Partials        6        6              
Files Coverage Δ
consumer.go 36.84% <100.00%> (ø)
consumer_config.go 17.80% <ø> (ø)
batch_consumer.go 57.62% <66.66%> (ø)
consumer_base.go 14.92% <0.00%> (ø)
message.go 70.00% <81.81%> (+3.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abdulsametileri
Copy link
Member Author

We can also merge this mr with nonbatch error implementation. In that case, we are considering returning []error array, etc. @emreodabas we can discuss further

@Abdulsametileri Abdulsametileri merged commit 38660af into main Nov 9, 2023
4 checks passed
@Abdulsametileri Abdulsametileri deleted the feature/#61 branch November 9, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants