Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 449 memory management #466

Closed
wants to merge 6 commits into from
Closed

Conversation

alvarosabu
Copy link
Member

Potentially closes #449

  • Recursive removal of nodes dispose (GPU) of all three disposable properties and removes refs (CPU) if the node is not primitive
  • If it is a primitive, the user needs to handle the disposal manually by using a dispose function

@alvarosabu alvarosabu self-assigned this Dec 10, 2023
@alvarosabu alvarosabu added bug Something isn't working performance labels Dec 10, 2023
Copy link

netlify bot commented Dec 10, 2023

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 547125d
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/657ac4eda9f8e60008c26aca
😎 Deploy Preview https://deploy-preview-466--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/core/nodeOps.ts Show resolved Hide resolved
node.dispose()
}

// Add invalidation code similar to https://github.com/pmndrs/react-three-fiber/blob/master/packages/fiber/src/core/utils.ts#L436
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an open todo?

@alvarosabu
Copy link
Member Author

@Tinoooo just to give you an update I'm waiting to merge #514 to v4 before continuing with this one.

@alvarosabu alvarosabu mentioned this pull request Feb 7, 2024
Closed
13 tasks
@alvarosabu
Copy link
Member Author

Closed in favor of #606

@alvarosabu alvarosabu closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance v4
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Memory leak caused by non disposed scene, when using routes
3 participants