Code refactored

[Domejko]

Description

I have done code refactoring #160. As I mentioned in comment I did shorten some nested if statements and when it was possible and clean looking made them one liners. Added a specific expected errors to the except blocks. In auth_backends.py I did change code accordingly because either way if user.check_password(password) was successful it did return user:

Before:

if user.check_password(password):
    if user.is_active:
        return user

    if user.awaiting_email_verification:
        return user
    return user

After:

if user.check_password(password):
    return user

From file create.py in /backend/views/core/invoices I did delete function named edit_invoice_page because it was exactly the same as this function:

@require_http_methods(["GET", "POST"])
def create_invoice_page(request: HttpRequest):
    if request.method == "POST":
        return invoice_page_post(request)
    return invoice_page_get(request)

and it have not been used anywhere in the code, so this function can be renamed to let say create_edit_invoice_page if would be needed for editing purposes anywhere in future.

I did noticed that some functions like edit_invoice are repeating through out the code with some slight changes here and there which possibly could be reduced to one function and repurposed with additional arguments. If you like I could try to work on that.

Hope you will be satisfied with those small changes.

Checklist

• Ran the Black Formatter and
  djLint-er on any new code
  (checks
  will
  fail without)
• Made any changes or additions to the documentation where required
• Changes generate no new warnings/errors
• New and existing unit tests pass locally with my
  changes

What type of PR is this?

• ♻️ Code Refactor

Added/updated tests?

• 🙅 no, because they aren't needed

Related PRs, Issues etc

• Related Issue #
• Closes #

[TreyWW]

Great cleanup! Really appreciate your contribution :)