initial setup fixes #240
initial setup fixes #240
Conversation
- removed generated bundle.js - removed generated output.css - updated tailwind build path - updated gitignore to exclude environment.yml confing, output.css and bundle.js
|
To be fair the output.css and bundle.js files are both quite nice to have, especially in deployments that get source directly from github releases that directly run the project and don't run npm run tailwind-build or webpack. There should be a better method then how we are currently doing it but fully removing it from source to me doesn't seem like the best idea. |
|
It's a bad practice to keep generated files in Git |
|
How you will guarantee that someone will generate and add to Git a proper file? |
|
Yeah I'm fine with it being added through CI, just don't want to pass nothing to git that's all. Any ideas how I'd pass the generated files through Github Actions onto master? |
|
You should keep generated files on the target server. You don't need to put it back to Git (even via CI) |
|
Oh i guess it could be added when we run docker build, that'd probably be the best place to have it. It just needs to be passed with source before it reaches the server in our case cause we just pull and run there isn't really room for any extra commands |
|
I can fix CI as well |
- removed duplicate Dockerfile - added frontend build at tests execution
- updated readme files for frontend
|
I'm done @TreyWW. |
Description
Checklist
djLint-er on any new code
(checks
will
fail without)
changes
What type of PR is this?
Added/updated tests?
Related PRs, Issues etc