Added keep-alive option to WCandidates #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
keep_alive_wcandidate
branch
3 times, most recently
from
d4c875e to
6be6092
Compare
qstokkink
changed the title
|
@devos50 Ready for review. All Pylint violations are |
7 tasks
qstokkink
changed the title
|
Marking as WIP:
|
qstokkink
force-pushed
the
keep_alive_wcandidate
branch
from
6be6092 to
7b30e9b
Compare
qstokkink
changed the title
devos50
reviewed
Jun 9, 2017
community.py
Outdated
| @@ -1069,6 +1069,12 @@ def unload_community(self): | |||
|
|
|||
| self.dispersy.detach_community(self) | |||
|
|
|||
| def is_loaded(self): | |||
| """ | |||
| Is this community attached to Dispersy | |||
There was a problem hiding this comment.
Comment looks a bit weird, I would propose something like Returns whether this community is attached to Dispersy.
qstokkink
changed the title
qstokkink
force-pushed
the
keep_alive_wcandidate
branch
from
7b30e9b to
39346e8
Compare
qstokkink
changed the title
|
@devos50 Fixed 👍 |
devos50
changed the title
|
@qstokkink thanks! |
devos50
approved these changes
Jun 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option for WalkCandidates to stay alive for a certain community (see
WalkCandidate.set_keepalive).Once the WalkCandidate determines it has timed out for its respective category (see
WalkCandidate.get_category), send a light-weight introduction request, without sync or advice so we are not introduced to new peers (seeCommunity.send_keep_alive). If this does not get answered with an introduction response within the next timeout cycle, the WalkCandidate is timed out after all.For developers
If your community wants to keep a certain WalkCandidate as long as possible, call
candidate.set_keepalive(community)to keep it until it goes offline. If you are no longer interested, callcandidate.set_keepalive(None).