[7.12.1] AssertionError in RestManager.stop()

[kozlovsky]

Sometimes AssertionError raises in RestManager.stop():

async def stop(self):
    ...
    if self.site:
        await self.site.stop()

The actual error happens in aiohttp.web_request.BaseRequest.__init__:

transport = self._protocol.transport
assert transport is not None

It seems that calling await self.site.stop() is not sufficient for a proper AIOHTTP shutdown, and the correct shutdown code should be:

await self.runner.shutdown()  # should be called before self.runner.cleanup()
await self.runner.cleanup()  # self.site.stop() is called inside this method

[sentry-for-tribler]

Sentry issue: TRIBLER-119