Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels on Discovered channels are missing #7395

Closed
xoriole opened this issue Apr 26, 2023 · 7 comments
Closed

Labels on Discovered channels are missing #7395

xoriole opened this issue Apr 26, 2023 · 7 comments
Assignees
Milestone

Comments

@xoriole
Copy link
Contributor

xoriole commented Apr 26, 2023

Describe the bug
The labels on Discovered channels are not shown on Ubuntu

To Reproduce
Steps to reproduce the behavior:

  1. Go to Channels / Discovered on the left sidebar.

Expected behavior
Labels like Name, Count, Popularity, Created at etc are visible.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):
tribler-channels-missing-labels

  • OS: Ubuntu 22.04
  • Tribler's version: release/7.13
@ichorid
Copy link
Contributor

ichorid commented Apr 26, 2023

Same setup, installed Tribler 7.13-rc1 from .deb package, the labels are OK 🤷

@xoriole
Copy link
Contributor Author

xoriole commented May 2, 2023

@ichorid you're right. The labels on 7.13-RC1 version are OK.

The issue is on current releases/7.13 branch. Running it from source or the build created from the branch, the issue is present. For example, you can check this build: https://jenkins-ci.tribler.org/job/Build-Tribler_release/job/Build-Ubuntu64/628/

Screenshot from 2023-05-02 13-19-08

@xoriole xoriole self-assigned this May 2, 2023
@xoriole xoriole changed the title Labels on Discovered channels are missing on Ubuntu Labels on Discovered channels are missing May 2, 2023
@xoriole
Copy link
Contributor Author

xoriole commented May 2, 2023

Also reproducible on the Windows version.

@ichorid
Copy link
Contributor

ichorid commented May 2, 2023

I binary-searched the problem over the commits. It was introduced in: 47d94b4

@kozlovsky
Copy link
Contributor

It looks like Qt expects pure str as a result of the QAbstractTableModel.headerData method. In other places it accepts str subclasses as well. #7402 fixes the issue.

@xoriole xoriole assigned kozlovsky and unassigned xoriole May 2, 2023
kozlovsky added a commit that referenced this issue May 3, 2023
…ders

Fixes #7395 "Labels on Discovered channels are missing"
@xoriole
Copy link
Contributor Author

xoriole commented May 3, 2023

With the latest fix merged on the release branch. Both running from source and build versions have labels. Tested for English only though.

@ichorid
Copy link
Contributor

ichorid commented May 3, 2023

Tested with Russian translation, fixed indeed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants