Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interactive tooltips #6713

Closed
wants to merge 1 commit into from

Conversation

ichorid
Copy link
Contributor

@ichorid ichorid commented Jan 7, 2022

Adds tooltips with clickable links to source channels to Popular and Search results pages.
partially fixes #6450

tool

@ichorid ichorid force-pushed the feature/interactive_tooltips branch 5 times, most recently from e7be1e7 to d95249a Compare January 7, 2022 23:23
@ichorid ichorid force-pushed the feature/interactive_tooltips branch from d95249a to 07c4afa Compare January 7, 2022 23:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ichorid ichorid mentioned this pull request Jan 18, 2022
@devos50
Copy link
Contributor

devos50 commented Jan 24, 2022

We have discussed this functionality in the weekly developer meetings. Similar to #6654, the consensus is that we do not have time to further pursue this approach at the moment. Instead, we would like to look into these kind of GUI improvements the moment when we are going to make changes to the way we organise and present content.

@devos50 devos50 closed this Jan 24, 2022
@ichorid
Copy link
Contributor Author

ichorid commented Jan 24, 2022

I've spent a week solving this. This PR is completely working, with no crashes. The only thing left to do is add GUI test. There is literally nothing to "pursue", just add a test. It does not even change the GUI appearance, so there is nothing to discuss in that regard either.

It makes me very sad to see how the team discards an important UX improvement that is basically ready and only requires a little bit of developer time to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Hard to navigate through search results
2 participants