Stricter signature for ErrorHandler.gui_error() #6846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
force-pushed
the
fix/gui_error_signature
branch
from
00f8219
to
54bc574
Compare
|
retest this please |
kozlovsky
force-pushed
the
fix/gui_error_signature
branch
from
54bc574
to
9d0f65c
Compare
|
retest this please |
1 similar comment
|
retest this please |
kozlovsky
requested review from
a team and
drew2a
and removed request for
a team
drew2a
previously approved these changes
Apr 6, 2022
kozlovsky
force-pushed
the
fix/gui_error_signature
branch
from
9d0f65c
to
a9d3e47
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kozlovsky
force-pushed
the
fix/gui_error_signature
branch
from
a9d3e47
to
e588249
Compare
|
retest this please |
1 similar comment
|
retest this please |
drew2a
force-pushed
the
main
branch
2 times, most recently
from
a8c07e5
to
5540c4f
Compare
drew2a
force-pushed
the
main
branch
2 times, most recently
from
2370caf
to
21168b4
Compare
kozlovsky
force-pushed
the
fix/gui_error_signature
branch
from
e588249
to
512620d
Compare
drew2a
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current signature of the
gui_errorfunction is not strict enough. In practice, the function is always called with three arguments. Because of insufficient checks, inside thegui_erorfunction, PyCharm shows warnings "local variable might be referenced before assignment". This PR fixes PyCharm warnings and makes variable names for the exception and the exception type more "traditional".Also, the PR uses the
caplogpytest fixture to check log messages in tests.