Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of workflows #6913

Merged
merged 2 commits into from
May 30, 2022
Merged

Refactoring of workflows #6913

merged 2 commits into from
May 30, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented May 25, 2022

This PR adds two new workflows:

  • !PR.yml for the event on: [pull_request]
  • !main.yml for the event on: [push: [branches: [main]]]

In these workflows, there are lists of child jobs that must be called for these events. It must simplify the understanding of which workflows runs on which event.

Eg:

name: Main

on:
  push:
    branches:
      - main

jobs:
  codacy:
    uses: ./.github/workflows/codacy.yml

  coverage:
    uses: ./.github/workflows/coverage.yml

  docker:
    uses: ./.github/workflows/docker-image.yml

  pytest:
    uses: ./.github/workflows/pytest.yml

All jobs besides these two are now triggered by the workflow_call event: https://docs.github.com/en/actions/using-workflows/reusing-workflows

@drew2a drew2a requested review from xoriole and kozlovsky May 25, 2022 12:45
@drew2a drew2a marked this pull request as ready for review May 25, 2022 15:58
@drew2a drew2a requested a review from a team May 25, 2022 15:58
@drew2a drew2a marked this pull request as draft May 25, 2022 15:59
@drew2a drew2a marked this pull request as ready for review May 25, 2022 17:35
@drew2a
Copy link
Contributor Author

drew2a commented May 30, 2022

@xoriole @kozlovsky I've added ubuntu build to the !PR.yml

@drew2a drew2a merged commit cf5abf3 into Tribler:main May 30, 2022
@drew2a drew2a mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants