Add the sign step to the windows build #6946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
feature/sign_win_build
branch
2 times, most recently
from
6da68f0
to
7b6617a
Compare
drew2a
force-pushed
the
main
branch
3 times, most recently
from
2370caf
to
21168b4
Compare
drew2a
force-pushed
the
feature/sign_win_build
branch
3 times, most recently
from
4e3cf67
to
6673a6d
Compare
drew2a
requested review from
a team,
xoriole and
kozlovsky
and removed request for
a team
xoriole
approved these changes
Jun 27, 2022
drew2a
force-pushed
the
feature/sign_win_build
branch
from
b723970
to
a814f63
Compare
drew2a
force-pushed
the
feature/sign_win_build
branch
from
a814f63
to
ce19814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the sign step to the windows build.
The certificate is stored as an environment secret base64 string.
See:
To continue the build procedure (and to get access to the secret), the approval of reviewers is needed. These reviewers are listed in the "Build" environment: https://github.com/Tribler/tribler/settings/secrets/actions
The windows build procedure will be the following (after merging to the main):