Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the WatchFolder #6966

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Refactor the WatchFolder #6966

merged 1 commit into from
Aug 18, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jul 7, 2022 •
edited
Loading

This PR contains refactoring of the Watch Folder.

Changes:

  1. TaskManager has been swapped to AsyncGroup.
  2. All Watch Folders errors now have the type of NoCrashException meaning that these errors will not stop Tribler.
  3. Logic of the Watch Folder has been simplified.
  4. Core now has the same error handling logic that GUI has (only the first exception of a given type will be shown).

This PR prepared Watch Folder Component for future fixing of #5833.

@drew2a drew2a force-pushed the fix/5833 branch 2 times, most recently from 035334a to 1884b10 Compare July 8, 2022 08:50
@drew2a drew2a marked this pull request as ready for review July 8, 2022 09:21
@drew2a drew2a requested review from a team and kozlovsky and removed request for a team July 8, 2022 09:21
@drew2a drew2a changed the title Fix/5833 Fix WatchFolder Jul 8, 2022
@drew2a drew2a force-pushed the fix/5833 branch 2 times, most recently from ff89248 to 48fbcd5 Compare July 14, 2022 05:23
@drew2a drew2a requested a review from kozlovsky July 14, 2022 05:40
@drew2a drew2a mentioned this pull request Jul 14, 2022
Closed
@drew2a drew2a marked this pull request as draft July 16, 2022 06:31
@drew2a drew2a changed the title Fix WatchFolder WIP: Fix WatchFolder Jul 16, 2022
@drew2a drew2a force-pushed the fix/5833 branch 5 times, most recently from 6a5c614 to 9c68dc8 Compare August 16, 2022 13:12
@drew2a drew2a changed the title WIP: Fix WatchFolder Refactor the WatchFolder Aug 16, 2022
@drew2a drew2a marked this pull request as ready for review August 17, 2022 10:23
@drew2a drew2a requested a review from kozlovsky August 17, 2022 10:34
@drew2a drew2a merged commit 55fe89a into Tribler:main Aug 18, 2022
@drew2a drew2a mentioned this pull request Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovsky kozlovsky kozlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drew2a @kozlovsky