Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GuiProcessWatcher tests #7042

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Fix GuiProcessWatcher tests #7042

merged 1 commit into from
Sep 9, 2022

Conversation

kozlovsky
Copy link
Contributor

This PR fixes a bug in test_gui_process_watcher tests that lead to the following warning:

RuntimeWarning: coroutine 'interval_runner' was never awaited

As GuiProcessWatcher is an instance of a TaskManager, it is necessary to call watcher.stop() at the end of the test to cancel all background tasks.

This PR adds a fixture for the GuiProcessWatcher instance that calls await watcher.stop() automatically at the end of the test.

@kozlovsky kozlovsky marked this pull request as ready for review September 8, 2022 16:22
@kozlovsky kozlovsky requested review from a team and drew2a and removed request for a team September 8, 2022 16:22
@kozlovsky kozlovsky merged commit 7808c05 into Tribler:release/7.12 Sep 9, 2022
@kozlovsky kozlovsky deleted the fix_gui_process_watcher_tests branch September 9, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew2a drew2a drew2a approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kozlovsky @drew2a