Add SSLError to exceptions
#7043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Sep 9, 2022
kozlovsky
approved these changes
Sep 9, 2022
| @@ -101,7 +99,8 @@ async def get_torrent_info(self, request): | |||
| elif scheme in (HTTP_SCHEME, HTTPS_SCHEME): | |||
| try: | |||
| response = await query_http_uri(uri) | |||
| except (ServerConnectionError, ClientResponseError) as e: | |||
| except (ServerConnectionError, ClientResponseError, SSLError) as e: | |||
| self._logger.warning(f'Error while querying http uri: {e}') | |||
| return RESTResponse({"error": str(e)}, status=HTTP_INTERNAL_SERVER_ERROR) | |||
There was a problem hiding this comment.
nitpick: Instead of 500 HTTP_INTERNAL_SERVER_ERROR, I'd use the "502 Bad Gateway" status here, as the error is not caused by some problem with the Tribler code. Also, the correct code on line 98 is probably "400 Bad Request". Ideally, code 500 should be for errors that should be fixed on the Tribler side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7035