Provide atomicity of state dir copying #7055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary directory with subsequent renaming
kozlovsky
requested review from
a team,
drew2a and
xoriole
and removed request for
a team
drew2a
approved these changes
Sep 20, 2022
| @@ -103,6 +108,9 @@ def __repr__(self): | |||
| def get_directory(self): | |||
| return self.root_state_dir / ('%d.%d' % self.major_minor) | |||
|
|
|||
| def get_tmp_copy_directory(self): | |||
| return self.root_state_dir / ('%d.%d_tmp_copy' % self.major_minor) | |||
There was a problem hiding this comment.
NIT: Maybe it is a bit safer to generate some random postfix for this temporary directory
Suggested change
| return self.root_state_dir / ('%d.%d_tmp_copy' % self.major_minor) | |
| major = self.major_minor[0] | |
| minor = self.major_minor[1] | |
| temporary_dir_name = f'{major}.{minor}_tmp_copy_{random.randrange(100)}' | |
| return self.root_state_dir / temporary_dir_name |
xoriole
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the source of #7002 by providing atomicity for state directory copying. To achieve that, it first copies the state into a temporary dir and then renames it to a correct name after the copying process is finished.
Also, it adds logging to the version manager, making it possible to see upgrade-related events in error reports.