Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows and macOS GUI tests to GitHub Actions #7115

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Oct 28, 2022

This PR closes #7086, closes #7087

To my great surprise, it worked out of the box.

The only one issue was "how to call a workflow with the custom matrix?".
The solution is to use fromJson for passing the matrix as a JSON object:

name: PR

on:
  pull_request:
    types:
      - opened
      - synchronize
      - ready_for_review

jobs:
  magic:
    uses: ./.github/workflows/magic.yml
    with:
      matrix: '{"os":["macos-latest","ubuntu-latest"]}'}
name: Magic

on:
  workflow_call:
      matrix:
        default: '{"os":["windows-latest"]}'
        type: string
        required: false

jobs:
  run:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix: ${{fromJson(inputs.matrix)}}

image

Refs:

@drew2a drew2a marked this pull request as ready for review October 28, 2022 10:58
@drew2a drew2a requested a review from a team October 28, 2022 10:58
@drew2a drew2a requested review from kozlovsky and xoriole and removed request for a team October 28, 2022 10:58
@drew2a drew2a marked this pull request as draft October 28, 2022 11:57
@drew2a drew2a changed the title Add Windows GUI tests to GitHub Actions Add Windows and macOS GUI tests to GitHub Actions Oct 28, 2022
@drew2a drew2a force-pushed the feature/7086 branch 2 times, most recently from 97a1c6b to 4916798 Compare October 28, 2022 12:48
@drew2a drew2a marked this pull request as ready for review October 28, 2022 13:02
@drew2a drew2a merged commit 79dedc9 into Tribler:main Oct 28, 2022
@drew2a drew2a deleted the feature/7086 branch October 28, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add macOS GUI tests to GitHub Actions Add Windows GUI tests to GitHub Actions
2 participants