-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix asyncio.create_task()
calls
#7300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
changed the title
Fix
WIP: Fix Feb 21, 2023
asyncio.create_task()
callsasyncio.create_task()
calls
drew2a
changed the title
WIP: Fix
Fix Feb 22, 2023
asyncio.create_task()
callsasyncio.create_task()
calls
kozlovsky
suggested changes
Feb 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I think I found some other places where asyncio.create_task
is used dangerously:
- In
Service._graceful_shutdown
, filehidden_peer_discovery.py
:
def _graceful_shutdown(self):
task = asyncio.create_task(self.on_tribler_shutdown())
task.add_done_callback(lambda result: TinyTriblerService._graceful_shutdown(self))
the variable is created, but its lifetime is shorter than the lifetime of the task.
- In
Service._graceful_shutdown
, filespeed_test_exit.py
- the same.
@kozlovsky thank you for your review. Two calls of |
kozlovsky
approved these changes
Feb 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7299
shutdown
method has been added to theRestEndpoint
base classList[Task]
has been added as a result value of theAsyncGroup.add()
callasyncio.create_task
have been fixed