Add tribler_stopped tag to the Sentry
#7365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
feature/add_stop_on_close
branch
from
7524d3f
to
84edbd7
Compare
drew2a
requested review from
a team,
xoriole and
kozlovsky
and removed request for
a team
drew2a
force-pushed
the
feature/add_stop_on_close
branch
from
84edbd7
to
ba827cf
Compare
kozlovsky
approved these changes
Apr 14, 2023
xoriole
approved these changes
Apr 14, 2023
drew2a
force-pushed
the
feature/add_stop_on_close
branch
from
ba827cf
to
171f02d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating issues from release
7.13,I realized having atribler_stoppedtag in the Sentry would be nice. That helps better understand the bug itself and distinguish the severity of the bug.If
tribler_stoppedis set toTrue, then it is a more severe bug than a bug withtribler_stoppedset toFalse.As a bonus, this PR adds correct typings for the field
additional_tags.